Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: polish the error message for generated column with default value #43669

Merged
merged 2 commits into from
May 11, 2023

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #22535

Problem Summary:

What is changed and how it works?

After the change, the error code and message is the same with MySQL.

Before:

mysql>  create table t1 (a int, b int as (a + 1) default 10);
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 52 near ")"Invalid column definition

After:

mysql> create table t1 (a int, b int as (a + 1) default 10);
ERROR 1221 (HY000): Incorrect usage of DEFAULT and generated column

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> create table t1 (a int, b int as (a + 1) default 10);
ERROR 1221 (HY000): Incorrect usage of DEFAULT and generated column
mysql> create table t1 (a int, b int as (a + 1) on update now());
ERROR 1221 (HY000): Incorrect usage of ON UPDATE and generated column
mysql> create table t1 (a int, b int as (a + 1) auto_increment);
ERROR 1221 (HY000): Incorrect usage of AUTO_INCREMENT and generated column
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 10, 2023
@tiancaiamao tiancaiamao requested a review from mjonss May 10, 2023 03:27
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 10, 2023
@tiancaiamao tiancaiamao requested a review from bb7133 May 10, 2023 03:27
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 10, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
@mjonss
Copy link
Contributor

mjonss commented May 11, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: ecbf910

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot merged commit bc98c8d into pingcap:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error info not compatible with MySQL for set generated columns default value
4 participants