-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add pre-commit #43343
*: add pre-commit #43343
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to tell everyone that they need to install bazel now.
We can add a guide to check the environment and tell developers what to install while they are running the pre-commit. BTW, pr-commit is not mandatory. |
Should the |
I don't want to force every developer to use pre-commit. It is optional. If you want to use it, you can |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 245fdf2
|
@hawkingrei You can send a PR against https://github.com/pingcap/tidb-dev-guide and share the written page among the community. May or may not just file an issue right now :) |
OK, I will do it and this PR will not close this issue. |
What problem does this PR solve?
Issue Number: ref #43346
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.