-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: fix generating region job is serialized #43123
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
} | ||
} | ||
return nil | ||
close(rangeCh) | ||
return eg.Wait() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a simper concurrency pattern:
eg, egCtx := errgroup.WithContext(ctx)
eg.SetLimit(local.RangeConcurrency)
for _, r := range jobRanges {
r := r
eg.Go(func() error {
....
}
}
eg.Wait()
Signed-off-by: lance6716 <lance6716@gmail.com>
/run-integration-br-test |
/run-integration-br-test |
/run-integration-br-test |
/run-integration-br-test last test failed on TiDB side |
/run-build-arm64 comment=true |
download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/86c52c149e8134c3b87a152dd800e1898285fce2/centos7/tidb-linux-arm64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 86c52c1
|
/retest |
2 similar comments
/retest |
/retest |
What problem does this PR solve?
Issue Number: close #42456
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.