Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: Choose left table as build table for semi join when left one is smaller for MPPTask #43064

Merged
merged 5 commits into from
Apr 19, 2023
Merged

plan: Choose left table as build table for semi join when left one is smaller for MPPTask #43064

merged 5 commits into from
Apr 19, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Apr 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #43062

pingcap/tiflash#7280

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve semi join and anti semi join performance of MPPTasks when left table has smaller size than right table.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 14, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 14, 2023

/test unit-test

1 similar comment
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test unit-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/cc @windtalker @SeaRise

SeaRise
SeaRise reviewed Apr 17, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

planner/core/exhaust_physical_plans.go Outdated
@@ -2387,6 +2387,9 @@ func (p *LogicalJoin) tryToGetMppHashJoin(prop *property.PhysicalProperty, useBC
}
} else if p.JoinType.IsSemiJoin() {
preferredBuildIndex = 1
if p.children[1].statsInfo().Count() > p.children[0].statsInfo().Count() {
preferredBuildIndex = 0
}
fixedBuildSide = true
Copy link
Contributor

@SeaRise SeaRise Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like fixedBuildSide = true is unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, make sense, will remove it.

@yibin87
Remove fixBuildSide assignment
1e4db7f 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87 yibin87 requested a review from SeaRise April 17, 2023 08:27
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test mysql-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test check-dev2

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test unit-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test check-dev2

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test mysql-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 17, 2023

/test unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 17, 2023
@yibin87
Reuse old flag to control if we enable right semi join
563c69c 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2023

/test unit-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2023

/test mysql-test

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2023

/test unit-test

windtalker
windtalker approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 18, 2023

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023
@yibin87
Fix tidb issue
9175251 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Limit to non-cross semi/anti-semi
dda0f62 
Signed-off-by: yibin <huyibin@pingcap.com>
@windtalker
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dda0f62

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Apr 19, 2023

/test check-dev

@yibin87
Copy link
Contributor Author

yibin87 commented Apr 19, 2023

/test unit-test

@ti-chi-bot ti-chi-bot merged commit 124abf6 into pingcap:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choose left table as build side for semi/anti join when left table is smaller
4 participants
@yibin87 @ti-chi-bot @windtalker @SeaRise