Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: reset jobs number #43023

Merged
merged 2 commits into from
Apr 20, 2023
Merged

*: reset jobs number #43023

merged 2 commits into from
Apr 20, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 13, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

EE team set too many concurrencies for tidb UT. so that many UT are very easy to become the unstable test for high CPU usage.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tiancaiamao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2023
@hawkingrei hawkingrei added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2023
@tiancaiamao
Copy link
Contributor

/run-all-tests

Let's check whether it become more stable.

@tiancaiamao
Copy link
Contributor

/test unit-test

@hawkingrei
Copy link
Member Author

/run-all-tests

Let's check whether it become more stable.

All test cases will hit the cache. so you need this #43008 to disable test cache.

@hawkingrei
Copy link
Member Author

hawkingrei commented Apr 13, 2023 •
edited
Loading

/test unit-test

It will be more stable? No, CI will still schedule the other task with tidb UT. it is possible to make high CPU usage.

@hawkingrei
Copy link
Member Author

/test unit-test

Let‘s see this #43034.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 13, 2023
@hawkingrei
*: reset jobs number
d6f02e7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2023
@hawkingrei
*: reset jobs number
4afad97 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 18, 2023
@hawkingrei
Copy link
Member Author

hawkingrei commented Apr 18, 2023 •
edited
Loading

This PR requires all team leaders approve to pass.

@hawkingrei hawkingrei requested a review from Benjamin2037 April 18, 2023 08:37
@hawkingrei hawkingrei requested a review from zanmato1984 April 18, 2023 08:37
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2023
@hawkingrei
Copy link
Member Author

/test all

@hawkingrei hawkingrei requested review from wjhuang2016 and ngaut April 20, 2023 13:58
lance6716
lance6716 approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an automatic way to adjust this value as time goes by?

@hawkingrei
Copy link
Member Author

Do we have an automatic way to adjust this value as time goes by?

I have the plan to make tool like Cockroach's dev tools. make bazel easier to use for developers. But for CI, we can use const config.

@qw4990
Copy link
Contributor

qw4990 commented Apr 20, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4afad97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2023
@ti-chi-bot ti-chi-bot merged commit 97a2796 into pingcap:master Apr 20, 2023
@hawkingrei hawkingrei deleted the reset_jobs branch April 21, 2023 02:50
@hawkingrei
Copy link
Member Author

/cherrypick release-7.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 4, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #43538.

In response to this:

/cherrypick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 11, 2023
@ti-chi-bot
*: reset jobs number (#43023) (#43538)
463759e 
close #43708
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request May 23, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #44089.

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 23, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#43023
7b151b6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@xhebox xhebox xhebox approved these changes

@lance6716 lance6716 lance6716 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@tangenta tangenta Awaiting requested review from tangenta

@bb7133 bb7133 Awaiting requested review from bb7133

@chrysan chrysan Awaiting requested review from chrysan

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@ngaut ngaut Awaiting requested review from ngaut

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkingrei @ti-chi-bot @tiancaiamao @qw4990 @lance6716 @xhebox