Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kazel: support auto-config shard_count #42751

Merged
merged 18 commits into from
Apr 6, 2023
Merged

kazel: support auto-config shard_count #42751

merged 18 commits into from
Apr 6, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 3, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42827

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@hawkingrei hawkingrei marked this pull request as draft April 3, 2023 05:46
@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@hawkingrei hawkingrei marked this pull request as ready for review April 4, 2023 07:30
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@hawkingrei hawkingrei force-pushed the kazel_set_shard_count branch from 0ddea87 to 7050092 Compare April 4, 2023 07:39
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2023
@hawkingrei hawkingrei force-pushed the kazel_set_shard_count branch from 06231d8 to 90387d5 Compare April 4, 2023 07:48
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2023
hawkingrei added 10 commits April 5, 2023 09:01
@hawkingrei
kazel: support auto-config shard_count
3455801 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
bde89b6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
36824a3 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
12dfe7f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
fedfcf9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
eda05a0 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
98693c8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
3e8be18 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
6c120cb 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
5e97dd2 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the kazel_set_shard_count branch from e81d55b to 5e97dd2 Compare April 5, 2023 01:28
@ti-chi-bot ti-chi-bot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 5, 2023
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2023
@hawkingrei
*: upgrade go 1.20.3
f9c01a8 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go 1.20.3
60f21f7 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: upgrade go 1.20.3
b182ea1 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
*: upgrade go 1.20.3
3ea9079 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
622e8e4 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
25a96d6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
lance6716
lance6716 reviewed Apr 6, 2023
View reviewed changes
@hawkingrei
update
e6153e6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
b2cc550 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei requested a review from lcwangchao April 6, 2023 06:34
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 6, 2023
@hawkingrei hawkingrei requested review from Defined2014 and xhebox April 6, 2023 06:34
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 6, 2023
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/merge

2 similar comments
@hawkingrei
Copy link
Member Author

/merge

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b2cc550

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 6, 2023
@ti-chi-bot ti-chi-bot merged commit e942ab6 into pingcap:master Apr 6, 2023
@ti-chi-bot
Copy link
Member

@hawkingrei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test b182ea1 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@Defined2014 Defined2014 Awaiting requested review from Defined2014

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support autoconfig for bazel's shard_count
4 participants
@hawkingrei @ti-chi-bot @lance6716 @xhebox