Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: calibrate resource support sysbench #42695

Merged
merged 5 commits into from
Apr 14, 2023
Merged

resource_control: calibrate resource support sysbench #42695

merged 5 commits into from
Apr 14, 2023

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Mar 30, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #38825

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

calibrate resource support sysbench

image

Signed-off-by: husharp jinhao.hu@pingcap.com

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 30, 2023
@HuSharp
import sysbench
cfeb990 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2023
@HuSharp
update parameters
1b78647 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp marked this pull request as ready for review April 12, 2023 02:46
@ti-chi-bot ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 12, 2023
@HuSharp
merge upstream
255f22c 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@HuSharp
make check happy
25ada00 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 12, 2023

/retest unit-test

@ti-chi-bot
Copy link
Member

@HuSharp: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/retest unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 12, 2023

/test unit-test

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 12, 2023

@glorv @nolouch @JmPotato PTAL, thx!

glorv
glorv reviewed Apr 12, 2023
View reviewed changes
parser/parser.y Outdated
CalibrateResourceWorkloadOption:
/* empty */
{
$$ = ast.TPCC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to set this default value at tidb side instead of in the parser. The default workload may change overtime, this way we can avoid change parser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a None type for marking

executor/calibrate_resource.go Outdated Show resolved Hide resolved
executor/calibrate_resource.go Outdated Show resolved Hide resolved
@HuSharp
update parameters
326e49f 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
glorv
glorv approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Apr 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 326e49f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2023
@Leavrth
Copy link
Contributor

Leavrth commented Apr 14, 2023

/test all

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/retest unit-test

@ti-chi-bot
Copy link
Member

@HuSharp: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/retest unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/test unit-test

4 similar comments
@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/test unit-test

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/test unit-test

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/test unit-test

@asddongmen
Copy link
Contributor

/test unit-test

@ti-chi-bot
Copy link
Member

@asddongmen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 14, 2023

/test unit-test

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot merged commit 15ce809 into pingcap:master Apr 14, 2023
@HuSharp HuSharp deleted the support_calibrate_sysbench branch April 14, 2023 10:33
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 14, 2023 •
edited
Loading

@HuSharp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build 1b78647 link true /test build
idc-jenkins-ci-tidb/unit-test 25ada00 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 1b78647 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@HuSharp HuSharp mentioned this pull request Apr 17, 2023
Merged
2 tasks
@nolouch nolouch mentioned this pull request Apr 19, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@glorv glorv glorv approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HuSharp @ti-chi-bot @Leavrth @asddongmen @hawkingrei @JmPotato @glorv