Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: refactor for reuse part2 #42626

Merged
merged 21 commits into from
Mar 28, 2023
Merged

lightning: refactor for reuse part2 #42626

merged 21 commits into from
Mar 28, 2023

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #40499

Problem Summary:

What is changed and how it works?

  • remove targetInfoGetter and EncodingBuilder from backend
  • remove dependency on glue from backend
  • make some struct public to reuse in load data

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 28, 2023
@D3Hunter D3Hunter requested a review from lance6716 March 28, 2023 02:47
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 28, 2023
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter D3Hunter requested a review from GMHDBJD March 28, 2023 03:00
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/retest

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

lance6716
lance6716 reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

23 / 41 files viewed

br/pkg/lightning/backend/local/local.go
tikvCli *tikvclient.KVStore
tls *common.TLS
pdAddr string
g glue.Glue
Copy link
Contributor

@lance6716 lance6716 Mar 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glue is to let lightning use its host TiDB's SQLExecutor, will we need it in future? such as lightning need TiDB's system session to write its checkpoint in a table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those're not the responsibility of backend, and if it really need we can pass in some object which handles it.

D3Hunter
D3Hunter commented Mar 28, 2023
View reviewed changes
types/types_test/const_test.go Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as expression pkg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted, so many cross dependencies😅

D3Hunter added 2 commits March 28, 2023 14:40
@D3Hunter
Revert "fix ut"t
fe08f7b 
This reverts commit c86b4be.
@D3Hunter
Revert "bazel"
5acfe6f 
This reverts commit 1c946d5.
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

3 similar comments
@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

cr pass https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/15749/pipeline

lance6716
lance6716 approved these changes Mar 28, 2023
View reviewed changes
executor/importer/import.go Outdated
return exeerrors.ErrLoadDataCantAccess.GenWithStackByArgs(GetMsgFromBRError(err))
}

dataFiles := []mydump.SourceFileMeta{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change its type to []*mydump.SourceFileMeta

executor/importer/import.go
LoadDataReadBlockSize,
nil,
false,
// TODO: support charset conversion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small git conflict with #42644

executor/load_data.go Outdated
}

parser, err2 = e.buildParser(ctx, reader, info.Remote)
dataParser, err2 := e.controller.GetParser(ctx, &info)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we can change GetParser(..., *LoadDataReaderInfo) to GetParser(..., LoadDataReaderInfo)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2023
GMHDBJD
GMHDBJD approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2023
@D3Hunter
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a69515

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2023
@ti-chi-bot ti-chi-bot merged commit 976148d into master Mar 28, 2023
@ti-chi-bot ti-chi-bot deleted the refactor-lit-part2 branch March 28, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D3Hunter @ti-chi-bot @lance6716 @GMHDBJD