Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: set short timeout as 120s #42396

Merged
merged 39 commits into from
Mar 21, 2023
Merged

bazel: set short timeout as 120s #42396

merged 39 commits into from
Mar 21, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 20, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

In bazel, The time limit for a test is based on its timeout attribute according to the following table:

image

But in the old test tools, our smallest timeout is 2m, so we need to reset it again as 120s.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2023
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Mar 20, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 20, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3cab764f5d110d74b30db787c76e3662db1687a8

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 20, 2023
@hawkingrei hawkingrei changed the title bazel: set short timeout as 120s bazel: set short timeout as 90s Mar 20, 2023
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6c5f4e325b15059df299960d7bdc3f898cb0449d

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 20, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fc35cf1c95064d1b3231b02bfc41d2f3a3ca1825

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/test unit-test

@hawkingrei
update
5dc7b88 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
a2f7a36 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
067cdfc 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
931a1f6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
fa9ba77 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
d570d5b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei hawkingrei force-pushed the reset_timeout_for_all_test branch from c85b5d2 to d570d5b Compare March 21, 2023 16:29
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d570d5b

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2023
@hawkingrei
update
1be5fff 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
bd85edf 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. labels Mar 21, 2023
@hawkingrei
update
caa124b 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
update
55a1cfa 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 55a1cfa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2023
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot ti-chi-bot merged commit 3c942f7 into pingcap:master Mar 21, 2023
@hawkingrei hawkingrei deleted the reset_timeout_for_all_test branch March 21, 2023 17:51
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 11, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #42932.

In response to this:

/cherrypick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 11, 2023
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#42396
81e1d05 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @tiancaiamao @lance6716