Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: change system variables name #42200

Merged
merged 4 commits into from
Mar 25, 2023
Merged

ddl: change system variables name #42200

merged 4 commits into from
Mar 25, 2023

Conversation

Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 commented Mar 14, 2023 •
edited
Loading

What problem does this PR solve?

This pr will change tidb_ddl_distribute_reorg to tidb_enable_dist_task to make the variables more suit for a unified distributed parallel execution framework parameter.

Issue Number: close #42186

Problem Summary:

What is changed and how it works?

Check List

Only change system variable name，no need add more test.
Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Benjamin2037 Benjamin2037 requested a review from a team as a code owner March 14, 2023 07:46
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-title do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 14, 2023
@Benjamin2037 Benjamin2037 changed the title ddl:Change system variables name ddl:change system variables name Mar 14, 2023
@Benjamin2037 Benjamin2037 changed the title ddl:change system variables name ddl: change system variables name Mar 14, 2023
@Benjamin2037 Benjamin2037 requested a review from zimulala March 14, 2023 08:48
@Benjamin2037 Benjamin2037 force-pushed the chang_variables_dist branch from b86a868 to 197ad73 Compare March 14, 2023 13:40
@Benjamin2037 Benjamin2037 changed the title ddl: change system variables name ddl: change system variables name （WIP） Mar 15, 2023
@Benjamin2037 Benjamin2037 force-pushed the chang_variables_dist branch from 95ff75c to f84a866 Compare March 21, 2023 01:33
@Benjamin2037 Benjamin2037 changed the title ddl: change system variables name （WIP） ddl: change system variables name Mar 21, 2023
@Benjamin2037
Copy link
Collaborator Author

/retest

@Benjamin2037
Copy link
Collaborator Author

/retest

bb7133
bb7133 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2023
@hawkingrei
Copy link
Member

/retest

2 similar comments
@Benjamin2037
Copy link
Collaborator Author

/retest

@Benjamin2037
Copy link
Collaborator Author

/retest

@Benjamin2037 Benjamin2037 requested a review from hawkingrei March 23, 2023 07:12
@Benjamin2037 Benjamin2037 requested a review from tangenta March 23, 2023 07:13
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 23, 2023
@Benjamin2037
Copy link
Collaborator Author

/retest

@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f84f872

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 24, 2023
@Benjamin2037
Copy link
Collaborator Author

/retest

@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot merged commit 922a5d3 into pingcap:master Mar 25, 2023
@tangenta tangenta mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@bb7133 bb7133 bb7133 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change tidb_ddl_distribute_reorg to tidb_dist_task
5 participants
@Benjamin2037 @ti-chi-bot @hawkingrei @tangenta @bb7133