Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: generate PointGet plans for prepare/execute statements #42194

Merged
merged 24 commits into from
Mar 16, 2023
Merged

planner: generate PointGet plans for prepare/execute statements #42194

merged 24 commits into from
Mar 16, 2023

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 14, 2023

What problem does this PR solve?

Issue Number: close #42125

Problem Summary: planner: generate PointGet plans for prepare/execute statements

What is changed and how it works?

planner: generate PointGet plans for prepare/execute statements

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2023
@hawkingrei
Copy link
Member

/retest

time-and-fate
time-and-fate reviewed Mar 14, 2023
View reviewed changes
planner/core/find_best_task.go Outdated Show resolved Hide resolved
planner/core/plan_cache_test.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@hawkingrei
Copy link
Member

/run-unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2023

/test unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Mar 14, 2023

/retest

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0adec31

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 16, 2023
@fzzf678
Copy link
Contributor

fzzf678 commented Mar 16, 2023

/retest

@fzzf678
Copy link
Contributor

fzzf678 commented Mar 16, 2023

/test unit-test

@fzzf678
Copy link
Contributor

fzzf678 commented Mar 16, 2023

/retest

@ti-chi-bot ti-chi-bot merged commit 7a93882 into pingcap:master Mar 16, 2023
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 24, 2023

/cherry-pick release-6.1

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 24, 2023

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 24, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@qw4990: new pull request created to branch release-6.1: #42553.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 24, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#42194
f5eda09 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@qw4990 qw4990 added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 29, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 29, 2023
Open
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #42672.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 29, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#42194
c65f1f8 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 29, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42673.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 29, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#42194
6de6fab 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 29, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #42674.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Mar 29, 2023
@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#42194
1abe5c6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Mar 29, 2023
Merged
Merged
Merged
ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2023
@qw4990
planner: generate PointGet plans for prepare/execute statements (#42194…
6602688 
…) (#42675)

close #42125
ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2023
@qw4990
planner: generate PointGet plans for prepare/execute statements (#42194…
0cf0a56 
…) (#42676)

close #42125
ti-chi-bot pushed a commit that referenced this pull request Mar 29, 2023
@qw4990
planner: generate PointGet plans for prepare/execute statements (#42194…
6e854ff 
…) (#42679)

close #42125
@Ryan-Git Ryan-Git mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@fzzf678 fzzf678 fzzf678 approved these changes

Assignees
No one assigned
Labels
epic/plan-cache needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

planner: cannot use BatchPointGet if Plan Cache is enabled in some cases
5 participants
@qw4990 @ti-chi-bot @hawkingrei @fzzf678 @time-and-fate