Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: skip plan cache if the plan contains Shuffle operators #42174

Merged
merged 6 commits into from
Mar 14, 2023
Merged

planner: skip plan cache if the plan contains Shuffle operators #42174

merged 6 commits into from
Mar 14, 2023

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Mar 13, 2023

What problem does this PR solve?

Issue Number: ref #38335

Problem Summary:

What is changed and how it works?

planner: skip plan cache if the plan contains Shuffle operators

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
@fzzf678 fzzf678 marked this pull request as ready for review March 13, 2023 13:51
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 13, 2023
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/retest

1 similar comment
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/retest

@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/run-mysql-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 14, 2023
@fzzf678 fzzf678 mentioned this pull request Mar 14, 2023
Closed
12 tasks
fzzf678
fzzf678 commented Mar 14, 2023
View reviewed changes
planner/core/common_plans.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6cd7d3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2023
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/run-mysql-test

@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/run-unit-test

1 similar comment
@fzzf678
Copy link
Contributor Author

fzzf678 commented Mar 14, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 828b52a into pingcap:release-5.4 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fzzf678 @ti-chi-bot @hawkingrei @qw4990 @VelocityLight