resource_control: support calibrate resource #42165

glorv · 2023-03-13T12:10:36Z

What problem does this PR solve?

Issue Number: ref #38825

Problem Summary:

What is changed and how it works?

This PR add a new statement calibrate resource to estimate the total Request-Units(RU) of the current cluster.
Because the total ru usage is related to workload resource consuming, so the maximum RU can be different with different workload. Thus, the maximum RU estimated by this PR is based on a given workload -- TPC-C, and we may support other workload(e.g. sysbench) in the future.

In general, the bottle of a cluster can be one of TiDB CPU, TiKV CPU, TiKV IO Bandwidth. Currently, we can get the exact IO bandwidth and for most workload, io is unlikely to be the bottleneck. So here, we only consider TiDB CPU or TiKV CPU as bottleneck.

For a specified workload, the resource consuming is linear co-related with each other. So this PR use pre-benchmarked data of each resource dimension to calculate the ru cost per 1 tikv cpu. So if tikv cpu is the bottleneck, then Max RU = max_ru_per_1_kv_cpu * Total_TiKV_CPU; if tidb cpu is the bottleneck, then we just decrease the total kv cpu with a certain portaion.

The PR calculate the RU cost of different resource dimension separated so we can support calculate total ru with custom ru config and the expected RU capacity can reflect the RU config change.

The current SQL UI is as follows(We may add more information in the future version):

mysql> calibrate resource;
+-------+
| QUOTA |
+-------+
| 68569 |
+-------+
1 row in set (0.18 sec)

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support estimate cluster total request unit with `calibrate resource`

ti-chi-bot · 2023-03-13T12:10:37Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JmPotato
nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2023-03-13T12:10:38Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

glorv · 2023-03-13T12:11:06Z

@nolouch @BornChanger PTAL

glorv · 2023-03-13T12:11:29Z

/test all

glorv · 2023-03-15T09:51:51Z

/retest

…te-resource

nolouch

Overall LGTM.

nolouch · 2023-03-16T08:46:04Z

executor/calibrate_resource.go

+		readBytes:     units.MiB / 2, // 0.5MiB
+		writeBytes:    units.MiB,     // 1MiB
+		readReqCount:  300,
+		writeReqCount: 1750,


Does it means 1 core can provide 1750 request in here? maybe add more comments.

Yes. It is based on benchmark result. I added comment on the baseResourceCost struct

…te-resource

JmPotato · 2023-03-17T05:21:59Z

executor/calibrate_resource.go

+		return err
+	}
+
+	workload := "tpcc"


What about using a const or defined type?

…te-resource

Connor1996 · 2023-03-17T06:56:41Z

executor/calibrate_resource.go

+	for i, f := range fields {
+		switch f.ColumnAsName.L {
+		case "instance":
+			//instanceIdx = i


please clean it

tiancaiamao

The result could be inaccurate.
It has many hypothesis, like the bottlenect is TiDB | TiKV CPU, like the workload assumption, like the performance on different hardware...

glorv · 2023-03-17T08:14:43Z

The result could be inaccurate. It has many hypothesis, like the bottlenect is TiDB | TiKV CPU, like the workload assumption, like the performance on different hardware...

Yes. This is the restriction of the current implementation. We plan to expand this command to support estimating the RU capacity based on user's workload dynamically, this should be more useful for the user.

glorv · 2023-03-17T08:15:00Z

/merge

ti-chi-bot · 2023-03-17T08:15:05Z

This pull request has been accepted and is ready to merge.

Commit hash: a6d48fb

support calibrate resource

ba15ffa

ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 13, 2023

glorv requested review from nolouch and BornChanger March 13, 2023 12:10

glorv added 2 commits March 14, 2023 11:25

fix

4d24b76

remove useless code

6ba21f1

Merge branch 'master' of https://github.com/pingcap/tidb into calibra…

b5f7dac

…te-resource

ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 16, 2023

glorv marked this pull request as ready for review March 16, 2023 04:06

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2023

glorv requested review from JmPotato and Connor1996 March 16, 2023 04:06

Merge branch 'master' of https://github.com/pingcap/tidb into calibra…

88b4582

…te-resource

nolouch reviewed Mar 16, 2023

View reviewed changes

add some comments

a2e5bea

nolouch approved these changes Mar 16, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2023

glorv added 3 commits March 16, 2023 17:45

Merge branch 'master' of https://github.com/pingcap/tidb into calibra…

b98a967

…te-resource

Merge branch 'master' of https://github.com/pingcap/tidb into calibra…

dcff95c

…te-resource

reformat code

5302f30

JmPotato reviewed Mar 17, 2023

View reviewed changes

use const

7325255

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2023

Merge branch 'master' of https://github.com/pingcap/tidb into calibra…

61ccb36

…te-resource

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2023

fix typo

d00788e

JmPotato approved these changes Mar 17, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2023

Connor1996 reviewed Mar 17, 2023

View reviewed changes

remove useless code

a6d48fb

tiancaiamao approved these changes Mar 17, 2023

View reviewed changes

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2023

ti-chi-bot merged commit 9632aa6 into pingcap:master Mar 17, 2023

CabinfeverB mentioned this pull request Apr 17, 2023

resource_control: support dynamic calibrate resource #43098

Merged

10 tasks

nolouch mentioned this pull request Apr 19, 2023

resource_control supports calibrate resource #43212

Closed

3 tasks

glorv deleted the calibrate-resource branch December 15, 2023 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resource_control: support calibrate resource #42165

resource_control: support calibrate resource #42165

glorv commented Mar 13, 2023 •

edited

Loading

ti-chi-bot commented Mar 13, 2023 •

edited

Loading

ti-chi-bot commented Mar 13, 2023

glorv commented Mar 13, 2023

glorv commented Mar 13, 2023

glorv commented Mar 15, 2023

nolouch left a comment

nolouch Mar 16, 2023

glorv Mar 16, 2023 •

edited

Loading

JmPotato Mar 17, 2023

glorv Mar 17, 2023

Connor1996 Mar 17, 2023

tiancaiamao left a comment

glorv commented Mar 17, 2023

glorv commented Mar 17, 2023

ti-chi-bot commented Mar 17, 2023

resource_control: support calibrate resource #42165

resource_control: support calibrate resource #42165

Conversation

glorv commented Mar 13, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Mar 13, 2023 • edited Loading

ti-chi-bot commented Mar 13, 2023

glorv commented Mar 13, 2023

glorv commented Mar 13, 2023

glorv commented Mar 15, 2023

nolouch left a comment

Choose a reason for hiding this comment

nolouch Mar 16, 2023

Choose a reason for hiding this comment

glorv Mar 16, 2023 • edited Loading

Choose a reason for hiding this comment

JmPotato Mar 17, 2023

Choose a reason for hiding this comment

glorv Mar 17, 2023

Choose a reason for hiding this comment

Connor1996 Mar 17, 2023

Choose a reason for hiding this comment

tiancaiamao left a comment

Choose a reason for hiding this comment

glorv commented Mar 17, 2023

glorv commented Mar 17, 2023

ti-chi-bot commented Mar 17, 2023

glorv commented Mar 13, 2023 •

edited

Loading

ti-chi-bot commented Mar 13, 2023 •

edited

Loading

glorv Mar 16, 2023 •

edited

Loading