Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: support audit log #42099

Merged
merged 44 commits into from
Apr 14, 2023
Merged

extension: support audit log #42099

merged 44 commits into from
Apr 14, 2023

Conversation

CbcWestwolf
Copy link
Member

@CbcWestwolf CbcWestwolf commented Mar 10, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #42188

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support new audit log in tidb enterprise version

@lcwangchao
*: import enterprise codes using go submodule
7e28076
@lcwangchao
audit: update enterprise version
3b8583c
@lcwangchao
Merge branch 'master' into audit_import
b43c71a
@lcwangchao
update enterprise version
2a9cfa0
@lcwangchao
update enterprise version
92fe7f7
@lcwangchao
update
875d7b8
@lcwangchao
update
f36a3f5
@lcwangchao
extension: add extension API for stmt events
0902cc2
@lcwangchao
update comments
1506685
@lcwangchao
udpate bazel
330a004
@lcwangchao
Merge branch 'extension_stmt_events' into audit_import
a500cc0
@lcwangchao
update
62b38f9
@lcwangchao
updat bazel lint
6244666
@lcwangchao
Merge branch 'extension_stmt_events' into audit_import
3333d69
@lcwangchao
update
d4c3ad3
@lcwangchao
Merge branch 'master' into audit_import
07051a2
@lcwangchao
update enterprise
7310bb6
@lcwangchao
update version
3e22cb0
@lcwangchao
update
7d7cc36
@lcwangchao
update
d38e434
@lcwangchao
Merge branch 'master' into audit_import
2609253
@lcwangchao
update
cf9d58c
@lcwangchao
Merge branch 'master' into audit_import
2e9154c
@lcwangchao
update
a48b0bc
@lcwangchao
update
4dbc330
@lcwangchao
update
7b1a7fd
@lcwangchao
Merge branch 'master' into audit_import
f63a957
@lcwangchao
Merge branch 'master' into audit_import
93fe443
@lcwangchao
update
2ac2a1b
@lcwangchao
update
3b7f5f7
lcwangchao
lcwangchao reviewed Mar 16, 2023
View reviewed changes
server/conn.go Outdated Show resolved Hide resolved
@CbcWestwolf
Copy link
Member Author

The timeout mechanism is also needed for writing audit log like #42212

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2023
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 27, 2023
@CbcWestwolf
change the submodule link
ab6a279 
TODO: update the hash value of extension/enterprise
@CbcWestwolf
Merge branch 'master' into audit_import
e8d66f1
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 13, 2023
bb7133
bb7133 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2023
@bb7133
Copy link
Member

bb7133 commented Apr 14, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e8d66f1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 14, 2023
@ti-chi-bot ti-chi-bot merged commit d01a6fd into pingcap:master Apr 14, 2023
@ti-chi-bot
Copy link
Member

@CbcWestwolf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test ab6a279 link true /test unit-test
idc-jenkins-ci-tidb/check_dev ab6a279 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lcwangchao lcwangchao mentioned this pull request Apr 24, 2023
Closed
@lcwangchao lcwangchao mentioned this pull request May 10, 2023
Merged
12 tasks
Mahmeoud19993
Mahmeoud19993 reviewed Sep 22, 2023
View reviewed changes
Copy link

@Mahmeoud19993 Mahmeoud19993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot

.gitmodules
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcwangchao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmeoud19993 Mahmeoud19993 Mahmeoud19993 left review comments

@bb7133 bb7133 bb7133 approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support audit log based on the extension framework
6 participants
@CbcWestwolf @ti-chi-bot @hawkingrei @bb7133 @lcwangchao @Mahmeoud19993