expression/expressions: replace iconv-go with text/transform #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove CGO requirement for compiling iconv-go currently is using. Replace it with native implementation of Go.
|
LGTM |
|
Updated PR. |
|
LGTM |
|
LGTM |
coocood
added a commit
that referenced
this pull request
Sep 7, 2015
expression/expressions: replace iconv-go with text/transform
|
@unknwon this function may be used in other places, we may move this to util as an alone package (e.g, iconv) later. |
😄 that's up to you. Not much differences for me. |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* add log for file info fix endTableID bug add schema test
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
…` and improve style (pingcap#42) * fix invalid config option * black_white_list: improve style
Defined2014
pushed a commit
to Defined2014/tidb
that referenced
this pull request
Apr 11, 2022
guoshouyan
pushed a commit
to guoshouyan/tidb
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove CGO requirement for compiling iconv-go currently is using.
Replace it with native implementation of Go.
maketest has passed, but test cases don't look very detailed onexpression, so not sure if everything will go well.Let's see if you are good with changes, then I'll do the godep thing.