Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: fix the issue that gc-worker owner cannot check log-backup task existed. (#41824) #41847

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41824

What problem does this PR solve?

Issue Number: close #41806
close #41642

Problem Summary:
If the gc-worker owner and the pitr owner is not the same node, the gc-worker owner cannot check the log-backup task existed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Manual test

  • Create a TiDB cluster with the 3 tidb-server, 3 pd-server and 3 tikv-server.
  • Create a log-backup task, Search the log in all of tidb-server, the log like this
2023-03-01 16:38:04 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 16:38:07 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 16:38:10 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
  • restart all of tidb-server, and search the log
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:11:27 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]
  • stop a log-backup task. Search the log
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:212] ["dec log backup task"] [count=0]
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:212] ["dec log backup task"] [count=0]
2023-03-01 17:13:02 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:212] ["dec log backup task"] [count=0]
  • start the log-backup task again, and search the log
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.32:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.31:4100[db.go:206] ["inc log backup task"] [count=1]
2023-03-01 17:13:50 (UTC+08:00)TiDB 10.2.5.20:4100[db.go:206] ["inc log backup task"] [count=1]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the issue that gc owner cannot check log-backup task existed

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved type/cherry-pick-for-release-6.4 labels Mar 2, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 2, 2023
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 38b614d link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 38b614d link true /test check-dev
idc-jenkins-ci-tidb/build 38b614d link true /test build
idc-jenkins-ci-tidb/unit-test 38b614d link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 38b614d link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants