Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: move some dist-reorg code to dist_* files and add the generate prefix key function #41577

Merged
merged 5 commits into from
Feb 20, 2023
Merged

ddl: move some dist-reorg code to dist_* files and add the generate prefix key function #41577

merged 5 commits into from
Feb 20, 2023

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41576

Problem Summary:

  • Move some dist-reorg code from backfilling.go to dist_* files (The code hasn't changed at all)
  • Add the function of generating prefix key and key, unified generating backfill job key.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 20, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 20, 2023
@zimulala
Copy link
Contributor Author

/retest

Defined2014
Defined2014 reviewed Feb 20, 2023
View reviewed changes
ddl/dist_backfilling.go Outdated Show resolved Hide resolved
ddl/dist_backfilling.go
}

// GetOracleTime returns the current time from TS without txn.
func GetOracleTime(store kv.Storage) (time.Time, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GetCurrentOracleTime is better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the original code, and this PR is just moving the position, I don't change the code here? Otherwise, the review will be troublesome

ddl/dist_backfilling.go Show resolved Hide resolved
@zimulala
Copy link
Contributor Author

/test check-dev

@pingcap pingcap deleted a comment from ti-chi-bot Feb 20, 2023
@zimulala
Copy link
Contributor Author

PTAL @Defined2014

Defined2014
Defined2014 reviewed Feb 20, 2023
View reviewed changes
ddl/ddl_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 20, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 20, 2023
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3cbdffa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 20, 2023
@ti-chi-bot ti-chi-bot merged commit 71fab02 into pingcap:master Feb 20, 2023
@zimulala zimulala deleted the zimuxia/tiny-update branch February 21, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move some dist-reorg code to dist_* files and add the generate prefix key function
4 participants
@zimulala @ti-chi-bot @hawkingrei @Defined2014