Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema: change schema of information_schema.resource_groups #41158

Closed
wants to merge 4 commits into from
Closed

infoschema: change schema of information_schema.resource_groups #41158

wants to merge 4 commits into from

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Feb 7, 2023 •
edited
Loading

Signed-off-by: BornChanger dawn_catcher@126.com

What problem does this PR solve?

Issue Number: Ref #38825

Problem Summary:

What is changed and how it works?

  1. Change information_schema.resource_groups to as below:

image

2 Fix a parser bug

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2023
@BornChanger
Copy link
Contributor Author

/cc @nolouch @glorv

@ti-chi-bot ti-chi-bot requested review from glorv and nolouch February 7, 2023 09:57
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 7, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8839750b8a464203fddb469aae72007e126b11e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@BornChanger
Copy link
Contributor Author

/retest

4 similar comments
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
infoschema: change schema of information_schema.resource_groups
2b4cdeb 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger
*: fix a parser bug
64eeca2 
Signed-off-by: BornChanger <dawn_catcher@126.com>
@BornChanger BornChanger force-pushed the change_is_resource_group branch from 5b825ab to 64eeca2 Compare February 8, 2023 09:29
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2023
@BornChanger BornChanger force-pushed the change_is_resource_group branch from 6e74586 to 64eeca2 Compare February 8, 2023 09:30
@BornChanger
Copy link
Contributor Author

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 64eeca2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@tiancaiamao
Copy link
Contributor

/retest

1 similar comment
@BornChanger
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Member

@BornChanger: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@BornChanger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 886a578 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BornChanger
Copy link
Contributor Author

/run-unit-test

@BornChanger
Copy link
Contributor Author

dup with #41174.

@BornChanger BornChanger closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BornChanger @ti-chi-bot @tiancaiamao @nolouch