-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add retry for prepare flashback for backup cluster is empty and there are only one region (#41059) #41119
br: add retry for prepare flashback for backup cluster is empty and there are only one region (#41059) #41119
Conversation
…here are only one region (pingcap#41059) close pingcap#41058
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
@fengou1: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/hold |
/test build |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e44733a
|
/unhold |
close #41058
What problem does this PR solve?
Issue Number: close #41058
Problem Summary:
when backup cluster is empty and there is only one region, BR assigned a leader and then do prepare a flashback immediately.
prepare flashback failed when a region was created without a leader.
region heartbeat sent may have some delay (10s), during the prepare flashback, the leader may not be sent heartbeat yet.
What is changed and how it works?
add retry for prepare flashback for specific errors.
Check List
Tests
step as issue description br: volume-snapshot backup and restore failure when backup cluster is empty and there are only one region #41058
- [ ] No code
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.