Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

privileges: add missing items for show privileges (#40600) | tidb-test=pr/2147 #40610

Merged
merged 2 commits into from
Jun 1, 2023
Merged

privileges: add missing items for show privileges (#40600) | tidb-test=pr/2147 #40610

merged 2 commits into from
Jun 1, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #40600

What problem does this PR solve?

Issue Number: close #40591

Problem Summary:

Now the result of show privileges misses 3 ones: CONFIG, Create role, and Drop role.

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jan 16, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CbcWestwolf
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 16, 2023
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 16, 2023
@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 16, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 16, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 3, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Apr 12, 2023
@CbcWestwolf
Copy link
Member

/reopen

@ti-chi-bot ti-chi-bot bot reopened this Jun 1, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 1, 2023

@CbcWestwolf: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CbcWestwolf
Copy link
Member

LGTM

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jun 1, 2023
@CbcWestwolf CbcWestwolf changed the title privileges: add missing items for show privileges | tidb-test=pr/2066 (#40600) privileges: add missing items for show privileges (#40600) Jun 1, 2023
@CbcWestwolf
Copy link
Member

/test mysql-test

@CbcWestwolf CbcWestwolf changed the title privileges: add missing items for show privileges (#40600) privileges: add missing items for show privileges (#40600) | tidb-test=pr/2147 Jun 1, 2023
@CbcWestwolf
Copy link
Member

/retest

1 similar comment
@CbcWestwolf
Copy link
Member

/retest

@CbcWestwolf
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 1, 2023

@CbcWestwolf: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 1, 2023
@CbcWestwolf
Copy link
Member

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 1, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e9d931b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit b3d604c into pingcap:release-6.5 Jun 1, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees

@CbcWestwolf CbcWestwolf

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @CbcWestwolf @xhebox @VelocityLight