*: fix some error related issues #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
shenli
reviewed
Aug 5, 2017
| @@ -257,7 +257,7 @@ func (e *Error) NotEqual(err error) bool { | |||
| // ToSQLError convert Error to mysql.SQLError. | |||
| func (e *Error) ToSQLError() *mysql.SQLError { | |||
| code := e.getMySQLErrorCode() | |||
| return mysql.NewErrf(code, e.getMsg()) | |||
| return mysql.NewErrf(code, "%s", e.getMsg()) | |||
There was a problem hiding this comment.
@shenli mysql.NewErr cannot be used here. It's functionality is not what we usually expected to be:
mysql.NewErr: NewErr generates a SQL error, with an error code and default format specifier defined in MySQLErrName.
func NewErr(errCode uint16, args ...interface{}) *SQLErrormysql.NewErrf: NewErrf creates a SQL error, with an error code and a format specifier.
func NewErrf(errCode uint16, format string, args ...interface{}) *SQLError
|
@breeswish Please resolve the conflicts. |
|
@shenli Done |
|
LGTM |
shenli
approved these changes
Aug 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: