Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:RFC for keyspace #39685

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

docs:RFC for keyspace #39685

wants to merge 35 commits into from

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented Dec 6, 2022

Signed-off-by: ystaticy y_static_y@sina.com

What problem does this PR solve?

Issue Number: ref #40425

Problem Summary:

What is changed and how it works?

Check List

Tests

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ystaticy <y_static_y@sina.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2022

CLA assistant check
All committers have signed the CLA.

@ystaticy ystaticy changed the title add keyspace rfc docs:RFC for keyspace Dec 6, 2022
Signed-off-by: ystaticy <y_static_y@sina.com>
iosmanthus and others added 2 commits December 9, 2022 16:53
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Add client-go and coprocessor section
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2022
This was referenced Jan 5, 2023
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.2399%. Comparing base (341503b) to head (16d9467).
Report is 191 commits behind head on master.

Current head 16d9467 differs from pull request most recent head bb2efa7

Please upload reports for the commit bb2efa7 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #39685        +/-   ##
================================================
+ Coverage   72.4329%   81.2399%   +8.8069%     
================================================
  Files          1491       2638      +1147     
  Lines        428997     717923    +288926     
================================================
+ Hits         310735     583240    +272505     
- Misses        99002     111483     +12481     
- Partials      19260      23200      +3940     

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Copy link

ti-chi-bot bot commented May 11, 2024

@AmoebaProtozoa: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
ystaticy and others added 15 commits May 15, 2024 11:20
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmoebaProtozoa, baiyuqing
Once this PR has been reviewed and has the lgtm label, please assign windtalker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 12, 2024

@baiyuqing: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
docs/design/2022-12-07-keyspace.md Outdated Show resolved Hide resolved
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Signed-off-by: y_static_y@sina.com <y_static_y@sina.com>
Copy link

ti-chi-bot bot commented Oct 14, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants