Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make check #39389

Merged
merged 1 commit into from
Nov 25, 2022
Merged

*: make check #39389

merged 1 commit into from
Nov 25, 2022

Conversation

MoCuishle28
Copy link
Contributor

Signed-off-by: Gaoming Zhang zhanggaoming028@gmail.com

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
make check for go1.19

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

run make check for go1.19

@MoCuishle28
make check
07bca3f 
Signed-off-by: Gaoming Zhang <zhanggaoming028@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • mengxin9014

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@MoCuishle28 MoCuishle28 requested a review from a team as a code owner November 25, 2022 05:27
@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 25, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 25, 2022
@MoCuishle28 MoCuishle28 changed the title make check *: make check Nov 25, 2022
@wuhuizuo
Copy link
Contributor

/run-mysql-test tidb-test=pr/1927

@wuhuizuo
Copy link
Contributor

/run-mysql-test tidb-test=pr/2023

@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2022
@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/2024

@hawkingrei
Copy link
Member

/run-mysql-test tidb-test=pr/2025

@hawkingrei
Copy link
Member

/run-unit-test
/run-check_dev

mengxin9014
mengxin9014 approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@mengxin9014 mengxin9014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 25, 2022
@hawkingrei
Copy link
Member

/run-check_dev

1 similar comment
@Ivy-YinSu
Copy link

/run-check_dev

@hawkingrei
Copy link
Member

/run-unit-test

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 07bca3f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2022
@MoCuishle28
Copy link
Contributor Author

/run-unit-test

1 similar comment
@Ivy-YinSu
Copy link

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 7b45f68 into pingcap:release-6.1 Nov 25, 2022
@zyguan zyguan mentioned this pull request Mar 24, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Mar 25, 2023
@zyguan
*: fix format check (#42569)
3282527 
ref #39389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mengxin9014 mengxin9014 mengxin9014 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MoCuishle28 @ti-chi-bot @wuhuizuo @hawkingrei @Ivy-YinSu @mengxin9014 @sre-bot