Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: add precheck about downstream CDC/PiTR #39338

Merged
merged 14 commits into from
Nov 30, 2022
Merged

lightning: add precheck about downstream CDC/PiTR #39338

merged 14 commits into from
Nov 30, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Nov 23, 2022 •
edited
Loading

Signed-off-by: lance6716 lance6716@gmail.com

What problem does this PR solve?

Issue Number: close #39346

Problem Summary:

What is changed and how it works?

When found target cluster has running CDC/PiTR tasks, lightning should not start importing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add a precheck for lightning that target cluster should not have running CDC/PiTR task

@lance6716
lightning: add precheck about downstream CDC/PiTR
4f924c6 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 23, 2022
@lance6716
add UT
846fc34 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2022
@lance6716 lance6716 changed the title [WIP]lightning: add precheck about downstream CDC/PiTR lightning: add precheck about downstream CDC/PiTR Nov 23, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@lance6716
fix bazel
39c6c43 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
change UT
d4a8fbe 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
add test about CDC etcd KV v6.1
1e8756b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
enable lightning check
25c592b 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-integration-br-tests

@lance6716
fix make errdoc
8973978 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2022
@lance6716
Copy link
Contributor Author

ptal @joccau @sdojjy

@lance6716
fix make bazel_prepare
7261e8a 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

/cc @dsdashun

@ti-chi-bot ti-chi-bot requested a review from dsdashun November 29, 2022 02:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 29, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@lance6716
Copy link
Contributor Author

/hold

forget to close etcd client

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@lance6716
fix unclosed client
25cd4d5 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@lance6716
Copy link
Contributor Author

/unhold
/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2022
@lance6716
Copy link
Contributor Author

/merge

3 similar comments
@lance6716
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor Author

/merge

@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 25cd4d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@lance6716
Copy link
Contributor Author

/run_check_dev_2

@lance6716
Copy link
Contributor Author

/run-check_dev_2

@lance6716
Copy link
Contributor Author

/run-build

@lance6716
fix make brietest
a450425 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a450425

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 328aef8 into pingcap:master Nov 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 1, success 25, total 26 5 min 2 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 11 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 58 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 20 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@lance6716 lance6716 mentioned this pull request Feb 6, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@3pointer 3pointer 3pointer approved these changes

@sdojjy sdojjy sdojjy approved these changes

@dsdashun dsdashun dsdashun approved these changes

@joccau joccau Awaiting requested review from joccau

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning should not use local backend to import to a CDC/PiTR cluster
8 participants
@lance6716 @ti-chi-bot @hawkingrei @sre-bot @dsdashun @sdojjy @3pointer @asddongmen