Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: make min start ts reporter aware of internal session from get_lock() #38790

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 1, 2022

What problem does this PR solve?

Issue Number: close #38706

Problem Summary:

Before this PR, the pessimistic transaction started by get_lock() can only live several minutes:

[WARN] [2pc.go:1118] ["stop TxnHeartBeat"] [error="txn 437065830059212803 heartbeat fail, primary key = 7480000000000000435f698000000000000001016100000000000000f8, err = txn 437065830059212803 not found"]

TiDB needs to report the minimal start ts to PD regularly, in order to advance the GC savepoint. However, the reporter is not aware of the pessimistic transaction started by get_lock(). When the GC worker cleans the lock record, the above error is reported.

What is changed and how it works?

This PR makes the min start ts reporter aware of get_lock() transaction.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
select get_lock('hello', 0);
...
[INFO] [2pc.go:1107] ["send TxnHeartBeat"] [startTS=437068143044853763] [newTTL=31000]
...
[INFO] [2pc.go:1107] ["send TxnHeartBeat"] [startTS=437068143044853763] [newTTL=2651034]

The lock could be hold for more than 40 mins.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix an issue that `get_lock()` cannot hold for more than 10 minutes.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ekexium
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.3 and removed do-not-merge/needs-triage-completed labels Nov 1, 2022
@ekexium
Copy link
Contributor

ekexium commented Nov 1, 2022

If a connection is closed without releasing the lock, will there be resource leak?

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2022
@tangenta
Copy link
Contributor Author

tangenta commented Nov 1, 2022

If a connection is closed without releasing the lock, will there be resource leak?

No. When the session closed, all the internal sessions will be returned to the pool.

s.ReleaseAllAdvisoryLocks()

@tangenta tangenta changed the title session: use sessionPool to get internal session for get_lock() session: make min start ts reporter aware of internal session from get_lock() Nov 1, 2022
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why not getting a session from the session pool?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2022
@tangenta
Copy link
Contributor Author

tangenta commented Nov 1, 2022

Just curious, why not getting a session from the session pool?

Because the variables of the session in pool is undetermined, it may cause the integration test fail. To minimize the unstable cases, it is better to use a new session like before :(

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@tangenta
Copy link
Contributor Author

tangenta commented Nov 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9b3e6b2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 2, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38827.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38828.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 2, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 21 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 28 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 34 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 48 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 26 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot added a commit that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET_LOCK() does not take the possibility of losing pessimistic locks into consideration
5 participants