Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix a bug that 'flashback table' does not handle mysql.gc_delete_range correctly (#38038) #38052

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 21, 2022

cherry-pick #38038 to release-6.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/38052

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/38052:release-6.3-5aab87679fde

What problem does this PR solve?

Issue Number: close #37386

Problem Summary:

What is changed and how it works?

@crazycs520 regard the element_id of mysql.gc_delete_range as table ID mistakenly...
So the constructed SQL from deleting the gc_delete_range record is wrong.

element_id is not table id, it's just an ID to distinguish multiple records within a job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

unistore doesn't implement the flashback table utilities, so I can't write the unit test.
I verified that #37386 is solved after this change.
And also,

create table pt (id int) partition by hash(id) partitions 5;
drop table pt;
flashback table pt;
create table a (id int);
create table b (id int);
drop table a,b;
flashback table b;
truncate table b;
flashback table b;

Check the gc_delete_range is correct in each step.

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug that 'flashback table' does not handle `mysql.gc_delete_range` correctly, this bug make the 'flashback table' feature almost unavailable.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 21, 2022
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.3-cherry-pick labels Sep 21, 2022
@ti-srebot
Copy link
Contributor Author

@tiancaiamao you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 21, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 21, 2022
@tiancaiamao
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 21, 2022
@wuhuizuo
Copy link
Contributor

/run-unit-test

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71e5453

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 21, 2022
@hawkingrei
Copy link
Member

/run-build

@ti-chi-bot ti-chi-bot merged commit 77fbcaf into pingcap:release-6.3 Sep 21, 2022
@tiancaiamao tiancaiamao deleted the release-6.3-5aab87679fde branch September 22, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.3-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants