Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: add test #3727

Merged
merged 2 commits into from
Jul 13, 2017
Merged

statistics: add test #3727

merged 2 commits into from
Jul 13, 2017

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 12, 2017

Improve the test coverage from 77.7% to 83.1%.
PTAL @hanfei1991 @winoros

@hanfei1991
Copy link
Member

LGTM

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2017
winoros
winoros approved these changes Jul 13, 2017
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winoros winoros added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2017
@alivxxx alivxxx merged commit f9c62ee into master Jul 13, 2017
@alivxxx alivxxx deleted the xhb/stats_test branch July 13, 2017 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @hanfei1991 @winoros