Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: enable announcerc #37217

Merged
merged 7 commits into from
Aug 19, 2022
Merged

bazel: enable announcerc #37217

merged 7 commits into from
Aug 19, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 18, 2022

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close None

Problem Summary:

What is changed and how it works?

make bazel print the info about bazel config.

图片

you can see the option context after enable it.

[2022-08-19T05:55:26.253Z]   Inherited 'common' options: --isatty=0 --terminal_columns=80

[2022-08-19T05:55:26.253Z] INFO: Reading rc options for 'build' from /home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/tidb/.bazelrc:

[2022-08-19T05:55:26.253Z]   'build' options: --announce_rc --java_language_version=17 --java_runtime_version=17 --tool_java_language_version=17 --tool_java_runtime_version=17 --incompatible_strict_action_env --incompatible_enable_cc_toolchain_resolution

[2022-08-19T05:55:26.253Z] INFO: Found applicable config definition build:ci in file /home/jenkins/agent/workspace/tidb_ghpr_build/go/src/github.com/pingcap/tidb/.bazelrc: --color=yes --experimental_remote_cache_compression

[2022-08-19T05:55:26.253Z] INFO: Found applicable config definition build:ci in file /data/bazel: --remote_cache=http://bazel-cache.pingcap.net:8080/tidb --remote_timeout=10s

[2022-08-19T05:55:26.515Z] Loading: 

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Run in CI

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 18, 2022

@hawkingrei hawkingrei requested review from xhebox and tangenta August 19, 2022 05:45
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2022
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know what announce_rc is, but maybe give a description.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2022
@hawkingrei hawkingrei requested a review from Defined2014 August 19, 2022 09:13
@hawkingrei
Copy link
Member Author

I know what announce_rc is, but maybe give a description.

update the PR description.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd89778

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2022
@ti-chi-bot ti-chi-bot merged commit 8b5b724 into pingcap:master Aug 19, 2022
@hawkingrei hawkingrei deleted the announce_rc branch August 19, 2022 11:07
@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 25 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 51 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 11 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants