Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumpling: update gc life_time hint #37189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

dumpling: update gc life_time hint #37189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7bbef1
update hint
lichunzhu Aug 18, 2022
d7daa1e
Merge branch 'master' into updateDumplingHint
lichunzhu Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dumpling/export/dump.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,9 +1446,9 @@ func tidbStartGCSavepointUpdateService(d *Dumper) error {
go updateServiceSafePoint(tctx, d.tidbPDClientForGC, defaultDumpGCSafePointTTL, snapshotTS)
} else if si.ServerType == version.ServerTypeTiDB {
tctx.L().Warn("If the amount of data to dump is large, criteria: (data more than 60GB or dumped time more than 10 minutes)\n" +
"you'd better adjust the tikv_gc_life_time to avoid export failure due to TiDB GC during the dump process.\n" +
"Before dumping: run sql `update mysql.tidb set VARIABLE_VALUE = '720h' where VARIABLE_NAME = 'tikv_gc_life_time';` in tidb.\n" +
"After dumping: run sql `update mysql.tidb set VARIABLE_VALUE = '10m' where VARIABLE_NAME = 'tikv_gc_life_time';` in tidb.\n")
"you'd better adjust the tidb_gc_life_time to avoid export failure due to TiDB GC during the dump process.\n" +
"Before dumping: run sql `set global tidb_gc_life_time = '24h';` in tidb.\n" +
"After dumping: run sql `set global tidb_gc_life_time = '10m';` in tidb.\n")
}
return nil
}
Expand Down