Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement castTimeAsDuration function pushdown #37036

Merged
merged 12 commits into from
Aug 15, 2022
Merged

expression: implement castTimeAsDuration function pushdown #37036

merged 12 commits into from
Aug 15, 2022

Conversation

AntiTopQuark
Copy link
Contributor

@AntiTopQuark AntiTopQuark commented Aug 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37033
related issue: pingcap/tiflash#5306
Problem Summary:
support castTimeAsDuration in tiflash

What is changed and how it works?

  1. open pushdown of castTimeAsDuration
  2. add some test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support to pushdown castTimeAsDuration to TiFlash

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • guo-shaoge

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2022
@AntiTopQuark AntiTopQuark mentioned this pull request Aug 10, 2022
Merged
12 tasks
@AntiTopQuark
Copy link
Contributor Author

/run-all-tests

@AntiTopQuark
Copy link
Contributor Author

/cc @SeaRise

@AntiTopQuark
Copy link
Contributor Author

/run-unit-test

SeaRise
SeaRise reviewed Aug 11, 2022
View reviewed changes
planner/core/integration_test.go Outdated Show resolved Hide resolved
expression/expression.go Outdated Show resolved Hide resolved
@AntiTopQuark
Copy link
Contributor Author

/run-unit-test

SeaRise
SeaRise approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
@AntiTopQuark
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e8c036cea8db937184964860ca9f49a540b3eca8

@hawkingrei
Copy link
Member

/run-all-tests

@SeaRise
Copy link
Contributor

SeaRise commented Aug 15, 2022

/cc @ywqzzy

@ti-chi-bot ti-chi-bot requested a review from ywqzzy August 15, 2022 07:21
ywqzzy
ywqzzy approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@ywqzzy: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 15, 2022
@guo-shaoge
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72f0665

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 15, 2022
@ti-chi-bot ti-chi-bot merged commit a664d28 into pingcap:master Aug 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 15, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 33 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 22 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 31 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 19 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 54 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Willendless
Willendless reviewed Aug 15, 2022
View reviewed changes
expression/expr_to_pb_test.go
Comment on lines +1188 to +1192

// CastTimeAsDuration
function, err = NewFunction(mock.NewContext(), ast.Cast, types.NewFieldType(mysql.TypeDatetime), durationColumn)
require.NoError(t, err)
exprs = append(exprs, function)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these lines should be above line 1181

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#37115

@SeaRise SeaRise mentioned this pull request Aug 16, 2022
Closed
ti-chi-bot pushed a commit that referenced this pull request Aug 19, 2022
@SeaRise
expression: fix incorrect unit test from #37036 (#37115)
7d401c5 
close #37116
@sre-bot
Copy link
Contributor

sre-bot commented Aug 19, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 33 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 22 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 13 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@Willendless Willendless Willendless left review comments

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement castTimeAsDuration function push down to TiFlash
8 participants
@AntiTopQuark @ti-chi-bot @sre-bot @hawkingrei @SeaRise @guo-shaoge @ywqzzy @Willendless