-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br,lightning: S3 URL support assuming role #36893
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-integration-br-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/482091951d582a12c2bd818f487534aae97b3424 |
/run-integration-br-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
@@ -46,7 +46,7 @@ require ( | |||
github.com/pingcap/errors v0.11.5-0.20211224045212-9687c2b0f87c | |||
github.com/pingcap/failpoint v0.0.0-20220423142525-ae43b7f4e5c3 | |||
github.com/pingcap/fn v0.0.0-20200306044125-d5540d389059 | |||
github.com/pingcap/kvproto v0.0.0-20220711062932-08b02befd813 | |||
github.com/pingcap/kvproto v0.0.0-20220804022843-f006036b1277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this pr need to update kvproto
separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because in this commit pingcap/kvproto@f006036 , two fields are added into the S3 message . This PR will use the newly added fields to develop this feature. So I updated the kvproto version to include this commit.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 4820919
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
The new options should be documented in https://github.com/pingcap/docs-cn/blob/master/br/backup-and-restore-storages.md#s3-%E7%9A%84-url-%E5%8F%82%E6%95%B0. @dsdashun Can you please update the user doc? |
What problem does this PR solve?
Issue Number: close #36891
Problem Summary:
What is changed and how it works?
role-arn
andexternal-id
role-arn
is set, assume the given role to access the S3 objects.Check List
Tests
data-source-url
to an S3 URL with 'role-arn' and 'external-id' set. For example:s3://my-testing-data/my-dir/?role-arn=arn:aws:iam::88888888:role%2Ftest-role&external-id=abcd1234
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.