Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade golang 1.18.5 #36788

Merged
merged 2 commits into from
Aug 2, 2022
Merged

*: upgrade golang 1.18.5 #36788

merged 2 commits into from
Aug 2, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Aug 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36857

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2022
@hawkingrei
*: upgrade go1.18.5
f934443 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2022
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Aug 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0f4592e4802759a545923670aa79102c54e402b0

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 2, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 2, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f934443

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 2, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

3 similar comments
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei
Copy link
Member Author

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 34d877a into pingcap:master Aug 2, 2022
@hawkingrei
Copy link
Member Author

/cherrypick release-6.2

@hawkingrei
Copy link
Member Author

/needs-cherry-pick-release-6.2

2 similar comments
@hawkingrei
Copy link
Member Author

/needs-cherry-pick-release-6.2

@hawkingrei
Copy link
Member Author

/needs-cherry-pick-release-6.2

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 3, 2022

/label needs-cherry-pick-release-6.2

@ti-chi-bot
Copy link
Member

@wuhuizuo: The label(s) needs-cherry-pick-release-6.2 cannot be applied. These labels are supported: challenge-program, compatibility-breaker, first-time-contributor, contribution, require-LGT3, good first issue, correctness, duplicate, proposal, security, needs-more-info, needs-cherry-pick-4.0, needs-cherry-pick-5.0, needs-cherry-pick-5.1, needs-cherry-pick-5.2, needs-cherry-pick-5.3, needs-cherry-pick-5.4, needs-cherry-pick-6.0, needs-cherry-pick-6.1, needs-cherry-pick-6.2, affects-4.0, affects-5.0, affects-5.1, affects-5.2, affects-5.3, affects-5.4, affects-6.0, affects-6.1, affects-6.2, may-affects-4.0, may-affects-5.0, may-affects-5.1, may-affects-5.2, may-affects-5.3, may-affects-5.4, may-affects-6.0, may-affects-6.1, may-affects-6.2.

In response to this:

/label needs-cherry-pick-release-6.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 3, 2022

/label needs-cherry-pick-6.2

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 3, 2022
@hawkingrei @ti-srebot
cherry pick pingcap#36788 to release-6.2
b197c33 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36858

ti-chi-bot pushed a commit that referenced this pull request Aug 3, 2022
@ti-srebot
*: upgrade golang 1.18.5 (#36788) (#36858)
c7a9d53 
close #36857
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Defined2014 Defined2014 Defined2014 approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
affects-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade golang1.18.5 for release-6.2
8 participants
@hawkingrei @ti-chi-bot @sre-bot @xhebox @wuhuizuo @ti-srebot @ngaut @Defined2014