Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: check virtual column for tiflash #36771

Merged
merged 4 commits into from
Aug 1, 2022
Merged

planner: check virtual column for tiflash #36771

merged 4 commits into from
Aug 1, 2022

Conversation

windtalker
Copy link
Contributor

@windtalker windtalker commented Aug 1, 2022 •
edited
Loading

Signed-off-by: xufei xufeixw@mail.ustc.edu.cn

What problem does this PR solve?

Issue Number: close #36773, close pingcap/tiflash#5513

Problem Summary:

What is changed and how it works?

TiFlash does not support virtual column, so if the table scan contains virtual column, it can not read from TiFlash

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@windtalker
check virtual column for tiflash
5ab6a78 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2022
@windtalker windtalker mentioned this pull request Aug 1, 2022
Closed
@windtalker
Copy link
Contributor Author

/run-check-issue-triage-complete

zanmato1984
zanmato1984 approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@XuHuaiyu XuHuaiyu added the type/bugfix This PR fixes a bug. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5ab6a78

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/rebuild

@windtalker
fix ci
0cd0bc8 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0cd0bc8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/rebuild

@windtalker
fix ci
542f0f5 
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 542f0f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@windtalker
Copy link
Contributor Author

/rebuild

1 similar comment
@windtalker
Copy link
Contributor Author

/rebuild

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/542f0f5e8f6b1c1de4d0bc14765a325636511f93

@ti-chi-bot ti-chi-bot merged commit dd2e076 into pingcap:master Aug 1, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 1, 2022
@windtalker @ti-srebot
cherry pick pingcap#36771 to release-6.0
87d6e6d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36784

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 1, 2022
@windtalker @ti-srebot
cherry pick pingcap#36771 to release-6.1
97a2888 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36785

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 1, 2022
@windtalker @ti-srebot
cherry pick pingcap#36771 to release-6.2
a2e918c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36786

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 7 min 34 sec New failing
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 36 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 52 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 55 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 45 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo pushed a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@windtalker @morgo
planner: check virtual column for tiflash (pingcap#36771)
6e667ba 
close pingcap/tiflash#5513, close pingcap#36773
morgo added a commit to morgo/tidb that referenced this pull request Aug 1, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sysvar-api-cleanup
a462ff1 
* upstream/master:
  ddl/schematracker: fix SetDDL will cause data race (pingcap#36768)
  planner: check virtual column for tiflash (pingcap#36771)
  *: replace defer clean with t.Cleanup (pingcap#36722)
  ddl: fix inaccurate row_count for `admin show ddl jobs` (pingcap#36716)
  config, sysvar: add config `instance.enable_ddl` and sysvar `tidb_enable_ddl` (pingcap#35425)
  *: enable part revive for all code (pingcap#36703)
ti-chi-bot pushed a commit that referenced this pull request Aug 2, 2022
@ti-srebot
planner: check virtual column for tiflash (#36771) (#36786)
29fbcdf 
close pingcap/tiflash#5513, close #36773
ti-chi-bot pushed a commit that referenced this pull request Aug 2, 2022
@ti-srebot
planner: check virtual column for tiflash (#36771) (#36785)
c5987a8 
close pingcap/tiflash#5513, close #36773
@chrysan chrysan mentioned this pull request Aug 3, 2022
Open
@windtalker windtalker deleted the check_virtual_column_for_tiflash branch October 23, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@LittleFall LittleFall LittleFall approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
7 participants
@windtalker @ti-chi-bot @sre-bot @ti-srebot @zanmato1984 @XuHuaiyu @LittleFall