Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix Merge hint for view #36678

Merged
merged 11 commits into from
Aug 1, 2022
Merged

planner: fix Merge hint for view #36678

merged 11 commits into from
Aug 1, 2022

Conversation

dayicklp
Copy link
Contributor

@dayicklp dayicklp commented Jul 28, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36666

Problem Summary:
When the CTE query has view, hint will not work. Because the current CTE's hint information will be overwritten in BuildView, so we save the CTE hint information and pass it back after BuildView.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • winoros
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-6.2 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2022
@dayicklp
Copy link
Contributor Author

The subquery in CTE which has Megre hint also has this issue, but this subquery will not go into buildSubquery, I need find a place to close it.

@dayicklp
Copy link
Contributor Author

/cc @winoros @wjhuang2016

@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2f8f2aaf82877587ea17ed1cb1c86b0fe0b338d6

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2022
@dayicklp
Copy link
Contributor Author

/run-mysql-test

@dayicklp dayicklp requested a review from winoros July 29, 2022 10:10
@dayicklp
Copy link
Contributor Author

/run-mysql-test

wjhuang2016
wjhuang2016 reviewed Aug 1, 2022
View reviewed changes
planner/core/logical_plan_builder.go Outdated
@@ -6693,7 +6714,8 @@ func (b *PlanBuilder) buildCte(ctx context.Context, cte *ast.CommonTableExpressi
}
b.buildingRecursivePartForCTE = saveCheck
} else {
p, err = b.buildResultSetNode(ctx, cte.Query.Query)
//When the query is CTE, we will turn the var to true.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is meaningless, you can remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 1, 2022
@dayicklp dayicklp requested a review from wjhuang2016 August 1, 2022 03:08
@dayicklp dayicklp requested a review from winoros August 1, 2022 03:40
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 1, 2022
@winoros
Copy link
Member

winoros commented Aug 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5dfd090

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 1, 2022
@ti-chi-bot ti-chi-bot merged commit 1f6f7da into pingcap:master Aug 1, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 1, 2022
@dayicklp @ti-srebot
cherry pick pingcap#36678 to release-6.2
16f8c0e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 1, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36760

@sre-bot
Copy link
Contributor

sre-bot commented Aug 1, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 18 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 18 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 19 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 5 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 57 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 50 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Aug 1, 2022
@ti-srebot
planner: fix Merge hint for view (#36678) (#36760)
c5718d7 
close #36666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"merge" hint in CTE with view will not work
6 participants
@dayicklp @ti-chi-bot @sre-bot @winoros @ti-srebot @wjhuang2016