Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: refactor the function #36603

Merged
merged 20 commits into from
Jul 28, 2022
Merged

planner: refactor the function #36603

merged 20 commits into from
Jul 28, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Jul 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary:
The GetPlanFromSessionPlanCache function has too much logic to read，before general plan cache we need do some finishing.

What is changed and how it works?

Split it into 4 functions.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@fzzf678
Update plan_cache.go
3f8ffde 
split GetPlanFromSessionPlanCache function into 4 functions
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 27, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1eb5094c267315ef4c7780155424d3b5ab483d81

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 27, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Jul 27, 2022

/run-mysql-test

@fzzf678
Copy link
Contributor Author

fzzf678 commented Jul 27, 2022

/cc @qw4990 @Reminiscent

@fzzf678 @Reminiscent
Apply suggestions from code review
c41cda1 
Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com>
Reminiscent
Reminiscent approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM. @qw4990 please take a look

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@Reminiscent Reminiscent requested a review from qw4990 July 28, 2022 08:12
@fzzf678 @Reminiscent
Apply suggestions from code review
816c7ff 
Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com>
qw4990
qw4990 reviewed Jul 28, 2022
View reviewed changes
planner/core/plan_cache.go Outdated
}

// getParamValue get real values for "?" in PREPARE statements
func getParamValue(sctx sessionctx.Context, isBinProtocol bool, binProtoVars []types.Datum,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming it to parseParamTypes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming it to parseParamTypes?

Oops，it's indeed type not value

qw4990
qw4990 reviewed Jul 28, 2022
View reviewed changes
planner/core/plan_cache.go Outdated
return nil, nil, false, nil
}

func rebuildPhysicalPlan(ctx context.Context, sctx sessionctx.Context, is infoschema.InfoSchema, preparedStmt *CachedPrepareStmt,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is used to generate a new plan for the current statement if there is no valid plan for it.
So a name like generateNewPlan seems better. Please rename it and add some comments.

qw4990
qw4990 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Jul 28, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1eb5094

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@ti-chi-bot ti-chi-bot merged commit 7eb79e6 into pingcap:master Jul 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 21 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 17 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 19 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 27 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 28 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 5 min 21 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 59 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fzzf678 @ti-chi-bot @sre-bot @qw4990 @hawkingrei @Reminiscent