-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: GC-aware memory track for analyze (#35248) #36380
base: release-6.1
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@chrysan please accept the invitation then you can push to the cherry-pick pull requests. Comment with |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ti-srebot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cherry-pick #35248 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36380
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34996 ref #33054
Problem Summary:
Resolve the gap of analyze memory track which is caused by gc trigger.
What is changed and how it works?
mysql> set global tidb_mem_quota_analyze=8589934592; // 8GB
mysql> analyze tpcc.customer with 0.05 samplerate;
Before:
success
After:
ERROR 1105 (HY000): analyze panic due to memory quota exceeds, please try with smaller samplerate(refer to 110000/count)
set 5G quota;
analyze table zto_ssmx_bill_detail; (with 160+ columns, 5G quota)
ERROR 1105 (HY000): analyze panic due to memory quota exceeds, please try with smaller samplerate(refer to 110000/count)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.