Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: do not acquire pessimistic lock for non-unique index keys #36229

Merged
merged 5 commits into from
Jul 26, 2022
Merged

executor: do not acquire pessimistic lock for non-unique index keys #36229

merged 5 commits into from
Jul 26, 2022

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Jul 15, 2022 •
edited
Loading

Signed-off-by: ekexium eke@fastmail.com

What problem does this PR solve?

Issue Number: close #36235

Problem Summary:

Fix the condition of checking if the index KV is unique or not.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

bugfix: do not acquire pessimistic lock for non-unique index keys

@ekexium
do not acqurie pessimistic lock on non-unique index keys
026e7f3 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022
@ekexium ekexium changed the title [DNM] executor: do not acqurie pessimistic lock on non-unique index keys [DNM] executor: do not acqurie pessimistic lock for non-unique index keys Jul 15, 2022
@ekexium
fix test
f6d84a6 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/71c038314fc8c313e6522bf91e3ec8eeee7476b5

@ekexium ekexium marked this pull request as ready for review July 15, 2022 06:28
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022
@ekexium ekexium changed the title [DNM] executor: do not acqurie pessimistic lock for non-unique index keys executor: do not acqurie pessimistic lock for non-unique index keys Jul 15, 2022
@ekexium
Copy link
Member Author

ekexium commented Jul 15, 2022

/run-all-tests

@TonsnakeLin
Copy link
Contributor

LGTM

@ti-chi-bot
Copy link
Member

@TonsnakeLin: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #36554

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-5.1
05df470 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #36555

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-5.2
39ca469 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #36556

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-5.3
71cdb09 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #36557

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-5.4
e68388b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #36559

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-6.0
92b7999 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #36560

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-6.1
2e18f53 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #36561

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 26, 2022
@ekexium @ti-srebot
cherry pick pingcap#36229 to release-6.2
2a4c11e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 26, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36562

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 26, 2022
@ekexium ekexium changed the title executor: do not acqurie pessimistic lock for non-unique index keys executor: do not acquire pessimistic lock for non-unique index keys Jul 26, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 26, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 14 min New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 59 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 39 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 12 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 3 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

ti-chi-bot pushed a commit that referenced this pull request Jul 27, 2022
@ti-srebot
executor: do not acqurie pessimistic lock for non-unique index keys (#…
f8c5da9 
…36229) (#36562)

close #36235
tiancaiamao pushed a commit to tiancaiamao/tidb that referenced this pull request Sep 1, 2022
@ekexium @tiancaiamao
executor: do not acqurie pessimistic lock for non-unique index keys (p…
5ec654e 
…ingcap#36229)

close pingcap#36235
ti-chi-bot pushed a commit that referenced this pull request Sep 1, 2022
@tiancaiamao
executor: do not acqurie pessimistic lock for non-unique index keys (#…
1ef17ca 
…36229) (#37547)
ti-chi-bot pushed a commit that referenced this pull request Nov 25, 2022
@ti-srebot
executor: do not acqurie pessimistic lock for non-unique index keys (#…
1f143c6 
…36229) (#36561)

close #36235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@tangenta tangenta tangenta approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pessimistic DML should not lock non-unique index keys
8 participants
@ekexium @ti-chi-bot @sre-bot @TonsnakeLin @wjhuang2016 @ti-srebot @tiancaiamao @tangenta