Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) server: refine JSON marshal for HTTP API #36214

Closed
wants to merge 1 commit into from
Closed

(WIP) server: refine JSON marshal for HTTP API #36214

wants to merge 1 commit into from

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Jul 14, 2022

What problem does this PR solve?

Issue Number: ref #35838

Problem Summary:

What is changed and how it works?

As described in the issue.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • NA

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2022
xhebox
xhebox reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we retrieve DDL jobs in batches, we can actually further stream JSON to reduce memory usage.

@tangenta
Copy link
Contributor

Is there a report about the memory comparison?

@xhebox
Copy link
Contributor

xhebox commented Aug 4, 2022

issue has been closed by #36859

@xhebox xhebox closed this Aug 4, 2022
@bb7133 bb7133 deleted the bb7133/json_http branch December 29, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox left review comments

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bb7133 @ti-chi-bot @tangenta @xhebox