-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: check the error returned by handleNoDelay
(#36105)
#36191
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@zyguan you're already a collaborator in bot's repo. |
@zyguan |
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/579b69afd18d97e48174c9e4bb25cb722246c695 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 579b69a
|
This pull request is closed because the related issue is triaged "Won't Fix". You can find more details at: |
cherry-pick #36105 to release-6.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/36191
After apply modifications, you can push your change to this PR via:
Signed-off-by: zyguan zhongyangguan@gmail.com
What problem does this PR solve?
Issue Number: close #35105
Problem Summary:
As described in #35105, statements might be partial commited by
explain analyze
.What is changed and how it works?
Also check the error returned by
handleNoDelay
(otherwise theerr
gets ignored whenhandled
is false).Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.