Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log-backup: add the switch for log backup #36115

Merged
merged 19 commits into from
Jul 15, 2022
Merged

log-backup: add the switch for log backup #36115

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b0f2213
log-backup: add switch for log backup
3pointer Jul 12, 2022
b9d640e
add test
3pointer Jul 12, 2022
b9a2395
fix test
3pointer Jul 12, 2022
96c7dab
fix test
3pointer Jul 12, 2022
0666771
fix leak test
3pointer Jul 12, 2022
a327e21
fix gc worker test
3pointer Jul 12, 2022
6039901
fix gc worker test
3pointer Jul 12, 2022
b46a99f
adjust test
3pointer Jul 13, 2022
c02b031
udpate code
3pointer Jul 14, 2022
cf483af
add example code for tidb
3pointer Jul 14, 2022
9bd6ff6
use sql instead of http api to get config
3pointer Jul 14, 2022
74e5299
remove useless code
3pointer Jul 14, 2022
ba4fc17
fmt
3pointer Jul 14, 2022
97b57ab
adjust code
3pointer Jul 14, 2022
5afb5c3
address comment
3pointer Jul 14, 2022
87c0041
fix build
3pointer Jul 14, 2022
23c4d88
address comment
3pointer Jul 14, 2022
6e512cc
Merge branch 'master' into add_switch_for_logbackup
3pointer Jul 15, 2022
721d1a4
Merge branch 'master' into add_switch_for_logbackup
ti-chi-bot Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
udpate code
  • Loading branch information
@3pointer
3pointer committed Jul 14, 2022
commit c02b03109668584cfd236818a22d345c3800f863
2 changes: 1 addition & 1 deletion br/pkg/utils/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ type DBExecutor interface {
// 3. Telemetry of log backup feature usage statistics.
// NOTE: this result shouldn't be cached by caller. because it may change every time in one cluster.
func IsLogBackupEnabled(ctx sqlexec.RestrictedSQLExecutor) bool {
var valStr = "show config where name = 'log-backup.enable'"
valStr := "show config where name = 'log-backup.enable'"
internalCtx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnBR)
rows, fields, errSQL := ctx.ExecRestrictedSQL(internalCtx, nil, valStr)
if errSQL != nil {
Expand Down