Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix ipv6 address #35881

Merged
merged 11 commits into from
Jul 5, 2022
Merged

lightning: fix ipv6 address #35881

merged 11 commits into from
Jul 5, 2022

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jul 1, 2022

What problem does this PR solve?

Issue Number: close #35880

Problem Summary:

What is changed and how it works?

see issue description

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix connect to tidb when using ipv6 host

@D3Hunter D3Hunter added the component/lightning This issue is related to Lightning of TiDB. label Jul 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/cc @gozssky @niubell @buchuitoudegou

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6166fc4b82c4f970685e8857bc3da9e2caeb2be0

lance6716
lance6716 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidb-tools has been moved to TiDB repo, does it also have this problem?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

tidb-tools has been moved to TiDB repo, does it also have this problem?

there're a lot of places joining host and port manually in tidb repo. in which case we can workaround by add square brace manually if they uses same way to join.

lightning join them using both ways

@sleepymole sleepymole changed the title db(lightning): fix ipv6 address lightning: fix ipv6 address Jul 1, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed do-not-merge/needs-triage-completed labels Jul 1, 2022
@sleepymole
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d8c3ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 1, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/run-integration-br-test

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2022
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/run-integration-br-test

1 similar comment
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 1, 2022

/run-mysql-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 4, 2022

/run-integration-br-test

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 4, 2022

br i t passed
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/12223/pipeline

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 4, 2022

/merge

1 similar comment
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 4, 2022

/merge

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jul 4, 2022

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
@ti-chi-bot ti-chi-bot merged commit 673f336 into pingcap:master Jul 5, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 5, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#35881 to release-5.3
6ff9b52 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #35930

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 5, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#35881 to release-5.4
df58d20 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #35931

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 5, 2022
@D3Hunter @ti-srebot
cherry pick pingcap#35881 to release-6.1
a1fecea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 5, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #35932

@D3Hunter D3Hunter deleted the fix-ipv6-address branch July 11, 2022 06:53
ti-chi-bot pushed a commit that referenced this pull request Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35932)
7b72995 
close #35880
ti-chi-bot pushed a commit that referenced this pull request Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35930)
91f4ca2 
close #35880
ti-chi-bot pushed a commit that referenced this pull request Jul 11, 2022
@ti-srebot
lightning: fix ipv6 address (#35881) (#35931)
5226a19 
close #35880
@D3Hunter D3Hunter mentioned this pull request Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@lance6716 lance6716 lance6716 approved these changes

@sleepymole sleepymole Awaiting requested review from sleepymole

@niubell niubell Awaiting requested review from niubell

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning failed to connect to tidb when using ipv6 host
8 participants
@D3Hunter @ti-chi-bot @sre-bot @sleepymole @ti-srebot @lance6716 @buchuitoudegou @hawkingrei