Skip to content

*: Add GeneralEventFromString to plugin.GeneralEvent (#34976) #34992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2022
Merged

*: Add GeneralEventFromString to plugin.GeneralEvent (#34976) #34992

merged 2 commits into from
May 27, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 27, 2022 •
edited
Loading

cherry-pick #34976 to release-6.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34992

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/34992:release-6.1-affcc9582aed

What problem does this PR solve?

Issue Number: ref #34963

What is changed and how it works?

This PR provides some methods to cast plugin.GeneralEvent to string value or string to plugin.GeneralEvent .

Release note

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lcwangchao @ti-srebot
cherry pick pingcap#34976 to release-6.1
a430f50 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2022
@ti-srebot ti-srebot mentioned this pull request May 27, 2022
Merged
1 task
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/6.1-cherry-pick labels May 27, 2022
@ti-srebot ti-srebot requested review from bb7133 and morgo May 27, 2022 01:55
@ti-srebot
Copy link
Contributor Author

@lcwangchao please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/07bbabbfc7526fee4398d4563c243b593546fe01

bb7133
bb7133 approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2022
@bb7133
Copy link
Member

bb7133 commented May 27, 2022

PTAL @morgo

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@lcwangchao
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a430f50

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit 31d4cd8 into pingcap:release-6.1 May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@lcwangchao lcwangchao

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/6.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @sre-bot @bb7133 @lcwangchao @morgo @VelocityLight