Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: enable list partition by default #34954

Merged
merged 3 commits into from
May 27, 2022
Merged

sessionctx: enable list partition by default #34954

merged 3 commits into from
May 27, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented May 25, 2022

What problem does this PR solve?

Issue Number: close #34953

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Make tidb_enable_list_partition on by default.

@mjonss mjonss requested a review from a team as a code owner May 25, 2022 12:10
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/368b75d961c0727c5b30cac2d6cb3c2b1f1a074e

bb7133
bb7133 approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@bb7133 bb7133 added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label May 26, 2022
@morgo morgo self-requested a review May 27, 2022 03:19
morgo
morgo approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As discussed, will make more changes in 6.2 and plan to remove feature flag.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2022
@morgo
Copy link
Contributor

morgo commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d40292

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit dae0a41 into pingcap:master May 27, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request May 27, 2022
@mjonss @ti-srebot
cherry pick pingcap#34954 to release-6.1
2d7cb8d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 27, 2022
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.1 in PR #34999

@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 40 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 39 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 37 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 54 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 2 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@mjonss mjonss deleted the list-partition-on-by-default branch May 27, 2022 08:24
@mjonss mjonss mentioned this pull request May 27, 2022
Closed
5 tasks
ti-chi-bot pushed a commit that referenced this pull request May 31, 2022
@ti-srebot
sessionctx: enable list partition by default (#34954) (#34999)
9bfd6be 
close #34953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable tidb_enable_list_partition by default
6 participants
@mjonss @ti-chi-bot @sre-bot @morgo @ti-srebot @bb7133