Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: migrate test-infra to testify for testSessionSerialSuite #34593

Merged
merged 4 commits into from
May 16, 2022
Merged

session: migrate test-infra to testify for testSessionSerialSuite #34593

merged 4 commits into from
May 16, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #28328

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2022
tisonkun
tisonkun reviewed May 12, 2022
View reviewed changes
session/session_test.go Outdated Show resolved Hide resolved
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f2f767e084e75eab9999cd9db20ac5593d35f532

@hawkingrei hawkingrei force-pushed the migrate_test branch 3 times, most recently from ca05804 to 3536ab2 Compare May 12, 2022 14:00
@hawkingrei hawkingrei force-pushed the migrate_test branch 5 times, most recently from cf39465 to 18fc799 Compare May 15, 2022 11:56
@hawkingrei hawkingrei requested a review from tisonkun May 15, 2022 13:45
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 15, 2022
@tisonkun
Copy link
Contributor

/cc @xhebox @disksing

@ti-chi-bot ti-chi-bot requested review from disksing and xhebox May 15, 2022 14:50
@hawkingrei hawkingrei requested a review from LittleFall May 15, 2022 14:53
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2022
@hawkingrei
fix
4b98bf6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@tisonkun tisonkun mentioned this pull request May 15, 2022
Closed
12 tasks
@hawkingrei hawkingrei requested a review from xiongjiwei May 16, 2022 04:58
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4b98bf6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2022
@ti-chi-bot ti-chi-bot merged commit f351f44 into pingcap:master May 16, 2022
@tisonkun
Copy link
Contributor

Great!

@hawkingrei hawkingrei deleted the migrate_test branch May 16, 2022 06:11
@sre-bot
Copy link
Contributor

sre-bot commented May 16, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 33, total 34 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 0 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 8 min 38 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 24 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 0 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 15 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@disksing disksing Awaiting requested review from disksing

@xhebox xhebox Awaiting requested review from xhebox

@LittleFall LittleFall Awaiting requested review from LittleFall

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @lcwangchao