Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pessimistictest: dedicated package for pessimistic txn tests #34353

Merged
merged 21 commits into from
May 3, 2022
Merged

pessimistictest: dedicated package for pessimistic txn tests #34353

merged 21 commits into from
May 3, 2022

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented May 1, 2022

Issue Number: close #28325

None

tisonkun added 5 commits May 1, 2022 10:17
@tisonkun
pessimistic tests on gha
878db71 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix test
f977011 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
test_db -> test
181096f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
pass with real tikv
b69822f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
fix create mock store
67b7b2d 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 1, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b769b9204fc70cfcf8ad00042c51ed002b49c9e3

tisonkun added 10 commits May 1, 2022 12:06
@tisonkun
fix setup tikv
b382f0e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
setup tikv with docker-compose
610737e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
need not check toml files license header
927cba3 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Setup TiKV cluster
c057b7e 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Setup TiKV cluster with tiup and less max-open-files config
9aa131d 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
avoid duplicate pessimistic tests workflow
2caa092 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
skip sleep test
bcd55ad 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
try to avoid sleep
77ec250 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Revert "try to avoid sleep"
acd8449 
This reverts commit 77ec250.
@tisonkun
skip sleep test
59067a4 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

tisonkun commented May 1, 2022

/cc @hawkingrei @xhebox

@ti-chi-bot ti-chi-bot requested review from hawkingrei and xhebox May 1, 2022 06:26
@tisonkun
structure code
63f80ff 
Signed-off-by: tison <wander4096@gmail.com>
@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2022
@hawkingrei hawkingrei added the status/LGT2 Indicates that a PR has LGTM 2. label May 1, 2022
@ti-chi-bot ti-chi-bot removed the status/LGT2 Indicates that a PR has LGTM 2. label May 1, 2022
@hawkingrei hawkingrei self-requested a review May 1, 2022 13:25
bb7133
bb7133 reviewed May 1, 2022
View reviewed changes
tests/pessimistictest/pessimistic_test.go
flag.Parse()
session.SetSchemaLease(20 * time.Millisecond)
config.UpdateGlobal(func(conf *config.Config) {
conf.TiKVClient.AsyncCommit.SafeWindow = 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we confirm that making SafeWindow=0 is a fine default value for all the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the setting from seesion/main_test.go. I tried to avoid unnecessary changes.

@tisonkun
Copy link
Contributor Author

tisonkun commented May 1, 2022

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@tisonkun
Copy link
Contributor Author

tisonkun commented May 1, 2022

@hawkingrei it seems @ti-chi-bot still not work so even we pass unit-test we cannot merge this pr :)

@hawkingrei
Copy link
Member

@hawkingrei it seems @ti-chi-bot still not work so even we pass unit-test we cannot merge this pr :)

I have applied for repairs, waiting for EE feedback. : (

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 2, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented May 2, 2022

/run-unit-test

@tisonkun
Copy link
Contributor Author

tisonkun commented May 2, 2022

@xhebox @bb7133 please git this PR another review >_<

@tisonkun
Copy link
Contributor Author

tisonkun commented May 2, 2022

I think @ti-chi-bot has just revived.

@hawkingrei hawkingrei requested a review from xhebox May 2, 2022 14:17
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 3, 2022
@xhebox
Copy link
Contributor

xhebox commented May 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63f80ff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 3, 2022
@ti-chi-bot ti-chi-bot merged commit fbe6015 into pingcap:master May 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 3, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 27 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 6 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 6 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 57 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 0 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 46 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao mentioned this pull request May 9, 2022
Closed
@tisonkun tisonkun mentioned this pull request May 17, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@disksing disksing Awaiting requested review from disksing

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for session/pessimistic_test.go
6 participants
@tisonkun @ti-chi-bot @sre-bot @xhebox @hawkingrei @bb7133