-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner, feedback: invalid the feedback when we turn off the feedback #34156
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/03e4b21289aba9aad7c172ba10f4d5a8b86607ce |
@Reminiscent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34156 +/- ##
================================================
- Coverage 63.5589% 63.5400% -0.0190%
================================================
Files 826 828 +2
Lines 269471 270203 +732
================================================
+ Hits 171273 171687 +414
- Misses 84636 84927 +291
- Partials 13562 13589 +27 |
What problem does this PR solve?
Issue Number: close #34155
Problem Summary:
invalid the feedback when we turn off the feedback
What is changed and how it works?
invalid the feedback when we turn off the feedback
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.