Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, feedback: invalid the feedback when we turn off the feedback #34156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Apr 21, 2022

What problem does this PR solve?

Issue Number: close #34155

Problem Summary:
invalid the feedback when we turn off the feedback

What is changed and how it works?

invalid the feedback when we turn off the feedback

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Apr 21, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 21, 2022

@ti-chi-bot
Copy link
Member

@Reminiscent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2022
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Please add this check in session.StoreQueryFeedback()

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.5400%. Comparing base (ecb0c98) to head (03e4b21).
Report is 7565 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #34156        +/-   ##
================================================
- Coverage   63.5589%   63.5400%   -0.0190%     
================================================
  Files           826        828         +2     
  Lines        269471     270203       +732     
================================================
+ Hits         171273     171687       +414     
- Misses        84636      84927       +291     
- Partials      13562      13589        +27     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The monitoring does not meet expectations after turning off the feedback
4 participants