Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table: fix NO_ZERO_DATE not work for insert into select statement #34101

Merged
merged 5 commits into from
Apr 26, 2022
Merged

table: fix NO_ZERO_DATE not work for insert into select statement #34101

merged 5 commits into from
Apr 26, 2022

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 19, 2022 •
edited
Loading

Signed-off-by: Jack Yu jackysp@gmail.com

What problem does this PR solve?

Issue Number: close #34099

Problem Summary: Fix it.

What is changed and how it works?

Remove bypassed condition of handleZeroDatetime.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@jackysp
table: fix NO_ZERO_DATE not work for insert into select statement
98b646f 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Apr 19, 2022
@jackysp
no cast
8ebc9ef 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 20, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/665bd890aeecc0b8f67099bb313cb9e90d4840c3

@jackysp
fix bug and add test case
290ce32 
Signed-off-by: Jack Yu <jackysp@gmail.com>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2022
@jackysp jackysp marked this pull request as ready for review April 20, 2022 03:34
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@jackysp jackysp requested review from coocood and qw4990 April 20, 2022 03:57
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2022
@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 290ce32

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2022
@tiancaiamao
Copy link
Contributor

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit b119f26 into pingcap:master Apr 26, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-4.0
db47af9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #34240

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-5.0
4665e71 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #34241

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-5.1
5a21b79 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #34242

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-5.2
7907940 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #34243

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-5.3
1ccb796 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #34244

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-5.4
004caa2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #34245

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 26, 2022
@jackysp @ti-srebot
cherry pick pingcap#34101 to release-6.0
2cbd523 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #34246

@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 9 min 49 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 9 min 9 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 34 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@coocood coocood Awaiting requested review from coocood

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/executor needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NO_ZERO_DATE not work for insert into select statement
6 participants
@jackysp @ti-chi-bot @sre-bot @tiancaiamao @ti-srebot @hawkingrei