Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: skip restoring schema name of CTE table columns (#33991) #34081

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 18, 2022

cherry-pick #33991 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34081

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/34081:release-5.4-3cf6b08e6b19

What problem does this PR solve?

Issue Number: close #33965

Problem Summary:

See #33965 (comment)

create view test.v as with tt as (select * from t) select * from tt;

This SQL should be restored to

WITH `tt` AS (SELECT `test`.`t`.`a` AS `a` FROM `test`.`t`) SELECT `tt`.`a` AS `a` FROM `tt`
                                                                   -- no schema name here

instead of

WITH `tt` AS (SELECT `test`.`t`.`a` AS `a` FROM `test`.`t`) SELECT `test`.`tt`.`a` AS `a` FROM `tt`

What is changed and how it works?

This PR prevent restoring the schema name of a column, if this column comes from a CTE table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 18, 2022
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.4-cherry-pick labels Apr 18, 2022
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 23, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 23, 2022

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 23, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 25252a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@bb7133
Copy link
Member

bb7133 commented Jun 23, 2022

/run-mysql-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Jun 23, 2022

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Jun 23, 2022

/run-mysql-test

1 similar comment
@bb7133
Copy link
Member

bb7133 commented Jun 23, 2022

/run-mysql-test

@tangenta
Copy link
Contributor

/run-mysql-test tidb-test=pr/1828

2 similar comments
@tangenta
Copy link
Contributor

/run-mysql-test tidb-test=pr/1828

@tangenta
Copy link
Contributor

/run-mysql-test tidb-test=pr/1828

@ti-chi-bot ti-chi-bot merged commit 10dd152 into pingcap:release-5.4 Jun 23, 2022
@heibaijian heibaijian added this to the v5.4.2 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants