-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix tables_priv table schema (#33599) #33604
session: fix tables_priv table schema (#33599) #33604
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@zimulala you're already a collaborator in bot's repo. |
PTAL @Defined2014 @bb7133 |
@@ -357,6 +357,14 @@ const ( | |||
last_analyzed_at TIMESTAMP, | |||
PRIMARY KEY (table_id, column_id) CLUSTERED | |||
);` | |||
// CreateTableCacheMetaTable stores the cached table meta lock information. | |||
CreateTableCacheMetaTable = `CREATE TABLE IF NOT EXISTS mysql.table_cache_meta ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove CreateTableCacheMetaTable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may affect the next cherry-pick classmates.
/merge |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: ee02aee
|
/merge |
/merge |
/merge |
/run-all-tests |
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #33599 to release-5.3
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/33604
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #33588
Problem Summary:
#28546 modify
tables_priv
andcolumns_priv
tables' column(Column_priv
) type. But it doesn't updatetables_priv
column in upgrade step.What is changed and how it works?
Check List
Tests
deploy a v5.2 cluster
upgrade to this PR.
execute SQL
Side effects
Documentation
Release note