Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Refactor FieldType structure #33569

Merged
merged 3 commits into from
Apr 26, 2022
Merged

*: Refactor FieldType structure #33569

merged 3 commits into from
Apr 26, 2022

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Mar 29, 2022 •
edited
Loading

Signed-off-by: BornChanger dawn_catcher@126.com

What problem does this PR solve?

Issue Number: close #32116

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2022
@BornChanger BornChanger force-pushed the master branch 2 times, most recently from 00b834e to 4d50c33 Compare March 29, 2022 17:11
@BornChanger
Copy link
Contributor Author

/run-mysql-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@hawkingrei hawkingrei self-requested a review March 30, 2022 07:50
@hawkingrei
Copy link
Member

@BornChanger

Please fix the linter.

BTW, It is too large for this review to review this pr. Can you split pr?

@hawkingrei
Copy link
Member

I think you can add the Getxxxx function into one pr and then refactor the usage of FieldType into the other.

@hawkingrei
Copy link
Member

I think you can add the Getxxxx function into one pr and then refactor the usage of FieldType into the other.

you can create a tracker issue to track your work. this pr is too large.

@hawkingrei hawkingrei added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022
@BornChanger
Copy link
Contributor Author

/run_check_dev_2

@BornChanger
Copy link
Contributor Author

/run_check_dev

@hawkingrei
Copy link
Member

/run-unit-test

@BornChanger
Copy link
Contributor Author

/run-mysql-test

@BornChanger
Copy link
Contributor Author

@BornChanger

Please fix the linter.

BTW, It is too large for this review to review this pr. Can you split pr?

linter issue is fixed. And I am not going to split the pr since the change is quite straight forward though more than 300 files are changed.

@BornChanger
Copy link
Contributor Author

/run-mysql-test

@BornChanger
Copy link
Contributor Author

/run-unit-test

@BornChanger
Copy link
Contributor Author

/run-mysql-test

@BornChanger
Copy link
Contributor Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/de8cdd5ca370673b88157bf3133dcb38a4ee81d3

@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@BornChanger
Copy link
Contributor Author

/run-check-dev

@BornChanger
Copy link
Contributor Author

/run-mysql-test

@BornChanger
Copy link
Contributor Author

/run-unit-test

@BornChanger
Copy link
Contributor Author

/run-integration-test-mysql-8022

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/merge

@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@ti-chi-bot ti-chi-bot merged commit 1bf64c6 into pingcap:master Apr 26, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 26, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 14 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 18 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 59 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 7 min 54 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 7 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 6 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 40 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Apr 29, 2022
@morgo
fix merge of pingcap#33569
1911dcf
@zanmato1984 zanmato1984 mentioned this pull request May 9, 2022
Closed
@tiancaiamao tiancaiamao mentioned this pull request May 9, 2022
Merged
12 tasks
This was referenced May 11, 2022
Closed
Merged
Merged
@Ehco1996 Ehco1996 mentioned this pull request May 25, 2022
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2022
Merged
This was referenced Jun 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@YangKeao YangKeao mentioned this pull request Oct 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@xhebox xhebox Awaiting requested review from xhebox

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring against runtime FieldType
7 participants
@BornChanger @ti-chi-bot @hawkingrei @sre-bot @xhebox @tiancaiamao @XuHuaiyu